Wireshark-commits: [Wireshark-commits] master-3.0 7dde281: Discard the upper bits of the "network"

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 Mar 2019 23:46:53 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7dde281ef1a975f42cce8e09bbb7782be23945cc
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

7dde281 by Guy Harris (guy@xxxxxxxxxxxx):

    Discard the upper bits of the "network" field in the file header.
    
    Libpcap's done that for a while; we should do so as well.
    
    (Ideally, we should use those bits, but there's an issue with pcapng,
    where the FCS length in the IDB is described as being in units of bits,
    but where we're treating it as being in units of bytes, that I'd like to
    resolve first.)
    
    Change-Id: Ibcb82f1dcaa8baae5bba55636cea8852a6af814e
    Reviewed-on: https://code.wireshark.org/review/32303
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 6d989b6d2c81493dacd0dd0b5091edf7f37e80d4)
    Reviewed-on: https://code.wireshark.org/review/32304
    

Actions performed:

    from  a86f05b   [Automatic update for 2019-03-03]
     add  7dde281   Discard the upper bits of the "network" field in the file header.


Summary of changes:
 wiretap/libpcap.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)