Wireshark-commits: [Wireshark-commits] master 3497356: ieee802154: fix compilation with gcc-4.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Mar 2019 10:21:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=349735613dc3e02340dc73a1dd5397310c4552c5
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3497356 by Dario Lombardo (lomato@xxxxxxxxx):

    ieee802154: fix compilation with gcc-4.
    
    Error:
    ../epan/dissectors/packet-ieee802154.c: In function 'dissect_ieee802154_header_ie':
    ../epan/dissectors/packet-ieee802154.c:3788:10: error: variable 'remaining' might be clobbered by 'longjmp' or 'vfork' [-Werror=clobbered]
         gint remaining = tvb_reported_length_remaining(tvb, offset) - IEEE802154_MIC_LENGTH(packet->security_level);
              ^
    
    Change-Id: I6dadaa9e502f8f38bf476b690395727c836172fd
    Reviewed-on: https://code.wireshark.org/review/32283
    Petri-Dish: Dario Lombardo <lomato@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  acb406f   DHCPv6: catch the NTP server suboptions being longer than the whole packet
     add  3497356   ieee802154: fix compilation with gcc-4.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)