Wireshark-commits: [Wireshark-commits] master 74a776d: Pull some common code from the FCS/metadata

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Mar 2019 02:26:14 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=74a776d391b6d7aa1d9662987cc3f09abfb8abaf
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

74a776d by Guy Harris (guy@xxxxxxxxxxxx):

    Pull some common code from the FCS/metadata dissectors.
    
    Put the "mark frames with an invalid CRC" stuff into the main dissector
    code, as it's the same regardless of whether you have an FCS that can be
    checked or metadata with an "FCS bad" flag.
    
    Change-Id: I2540c1934032c91f22b66babd81fb928212f18b5
    Reviewed-on: https://code.wireshark.org/review/32280
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  8ecb42a   Have separate routines to dissect an FCS and TI CC24xx metadata.
     add  74a776d   Pull some common code from the FCS/metadata dissectors.


Summary of changes:
 epan/dissectors/packet-ieee802154.c | 41 ++++++++++++++-----------------------
 1 file changed, 15 insertions(+), 26 deletions(-)