Wireshark-commits: [Wireshark-commits] master-3.0 f96f8b8: More "It's not a CRC, it's metadata".

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 27 Feb 2019 17:39:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f96f8b8ac2271633c9514da0ca575ea0a051ac5f
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

f96f8b8 by Guy Harris (guy@xxxxxxxxxxxx):

    More "It's not a CRC, it's metadata".
    
    Also ask, in a comment, how long the CRC is if we *do* have a CRC
    rather than metadata.
    
    Change-Id: I92da4d3ade9b69f65b39ea058915f3ee4530b786
    Reviewed-on: https://code.wireshark.org/review/32237
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 2307a6d64c3a9058c96cf51c0cb5ebaa3c6b3f0c)
    Reviewed-on: https://code.wireshark.org/review/32238
    

Actions performed:

    from  ff0dca5   rpcap: check conversation existence before dereferencing it.
     add  f96f8b8   More "It's not a CRC, it's metadata".


Summary of changes:
 epan/dissectors/packet-zep.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)