Wireshark-commits: [Wireshark-commits] master c5681ec: ARP: Various improvements

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 18 Feb 2019 05:19:19 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c5681ec342e490b19b0c71e5b588563450ebffa4
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c5681ec by Michael Mann (mmann78@xxxxxxxxxxxx):

    ARP: Various improvements
    
    1. Create a dissector table for ARP hardware type to more cleanly handle
    "non Ethernet" dissection.
    2. Move the creation of the ARP tree up higher to use proto_tree_add_item_ret_uint
    as well as have "Duplicate IP address detected" tree be after the ARP tree, not
    between Ethernet and ARP (implying it didn't come from ARP).
    
    Change-Id: I48c815b3e84f7d5f08ad1b731f16e7c1adef8247
    Reviewed-on: https://code.wireshark.org/review/32082
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  0000483   ARP: Add support for ARP Probe and ARP Announcement (RFC 5227)
     add  c5681ec   ARP: Various improvements


Summary of changes:
 epan/dissectors/packet-arp.c | 71 ++++++++++++++++++++++++--------------------
 1 file changed, 38 insertions(+), 33 deletions(-)