Wireshark-commits: [Wireshark-commits] master-3.0 a8ae31d: CMake: Move the PLUGIN_PATH_ID definitio

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 14 Feb 2019 02:23:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a8ae31d565d7ef68fd39d1921c7419d9d2af849a
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

a8ae31d by Gerald Combs (gerald@xxxxxxxxxxxxx):

    CMake: Move the PLUGIN_PATH_ID definition.
    
    Define PLUGIN_PATH_ID where we use it. ENABLE_APPLICATION_BUNDLE is
    defined later on, so test for APPLE instead.
    
    Change-Id: I16c3ac3dc0e483fbf89cb1a2cacb2afb416d656f
    Reviewed-on: https://code.wireshark.org/review/32016
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    (cherry picked from commit 469c1eb69297986b30f8c7f6e4f9d8391eafa1dc)
    Reviewed-on: https://code.wireshark.org/review/32019
    

Actions performed:

    from  310e2cd   macOS: Fix our plugin path.
     add  a8ae31d   CMake: Move the PLUGIN_PATH_ID definition.


Summary of changes:
 CMakeLists.txt | 35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)