Wireshark-commits: [Wireshark-commits] master aa1f314: Fix directory containing compiled plugins in

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Feb 2019 03:05:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=aa1f314464d7c490fc0f07d5bfc831af98be4315
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

aa1f314 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix directory containing compiled plugins in macOS.
    
    They weren't getting put in the version-number subdirectory, so the
    plugin loader wasn't finding them.
    
    If that causes problems with codesign, then we need to either
    
    	1) figure out how to make it work with codesign
    
    or
    
    	2) for macOS, not put plugins in a version-number subdirectory
    	   ***AND*** change the plugin loading process not to look for
    	   compiled in a version-number subdirectory.
    
    Change-Id: I58d344b728d05369d35edef4e4e530f10034e930
    Reviewed-on: https://code.wireshark.org/review/32000
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  80e33ff   MacOS: Fix a path.
     add  aa1f314   Fix directory containing compiled plugins in macOS.


Summary of changes:
 CMakeLists.txt                 | 17 +++++++++++------
 packaging/macosx/osx-app.sh.in |  2 +-
 2 files changed, 12 insertions(+), 7 deletions(-)