Wireshark-commits: [Wireshark-commits] master 2e13c4a: mqtt: document UTF-8 requirement for topic_s

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Feb 2019 18:19:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2e13c4adb29bbd8a9cf01e4ceda93d65dd377c14
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2e13c4a by Peter Wu (peter@xxxxxxxxxxxxx):

    mqtt: document UTF-8 requirement for topic_str
    
    If someone changes this in the future and the data is no longer valid
    UTF-8, then crashes can occur.
    
    Change-Id: I2b153d48ee1ef7093a5141001a391dd440c30e58
    Ping-Bug: 14905
    Reviewed-on: https://code.wireshark.org/review/31942
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  061ebbd   Fixing some implicit coversations (-Wshorten-64-to-32)
     add  2e13c4a   mqtt: document UTF-8 requirement for topic_str


Summary of changes:
 epan/dissectors/packet-mqtt.c | 2 ++
 1 file changed, 2 insertions(+)