Wireshark-commits: [Wireshark-commits] master ce6b5db: Have win32strerror() return a g_malloc()ated

Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 01 Feb 2019 04:17:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ce6b5dba47d296b6e97482c9e734341a0897e0ac
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ce6b5db by Guy Harris (guy@xxxxxxxxxxxx):

    Have win32strerror() return a g_malloc()ated UTF-8 error message.
    
    Use FormatMessageW() to get a UTF-16-encoded Unicode error string,
    rather than an error string in the local code page, and then convert it
    from UTF-16 to UTF-8.
    
    Make it dynamically-allocated, so it's big enough and so that we are
    thread-safe.  Make the callers free the result.
    
    Change-Id: I217aec5a644fa0176a829f181eb05561cb9d10f4
    Reviewed-on: https://code.wireshark.org/review/31846
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  768a746   wireshark: Free the if_stat_cache_t when dumpcap is not forked
     add  ce6b5db   Have win32strerror() return a g_malloc()ated UTF-8 error message.


Summary of changes:
 capchild/capture_sync.c | 30 ++++++++++++-------
 wsutil/win32-utils.c    | 76 +++++++++++++++++++++++++++++++++++--------------
 wsutil/win32-utils.h    |  9 +++---
 3 files changed, 80 insertions(+), 35 deletions(-)