Wireshark-commits: [Wireshark-commits] master-2.6 a92a763: Also check whether we have nothing but D

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Jan 2019 09:00:03 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a92a76310da9fe36578c94dab89d2ac19923a797
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

a92a763 by Guy Harris (guy@xxxxxxxxxxxx):

    Also check whether we have nothing but DLCI bytes.
    
    The two failure modes are 1) no byte has the low-order bit set, so we
    didn't even find the end of the DLCI or 2) the byte at the end of the
    packet has the low-order bit set, so that it's all DLCI with no control
    byte after it.
    
    Expand a comment.
    
    Bug: 15463
    Change-Id: Ib76686391213dd56c06d665aa87a188621fe6816
    Reviewed-on: https://code.wireshark.org/review/31828
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 9d79a936837bb91bb822ede898b95d4256f0c4ba)
    Reviewed-on: https://code.wireshark.org/review/31829
    

Actions performed:

    from  cf61dd42  Check whether you've hit the end of the packet data before going further.
     add  a92a763   Also check whether we have nothing but DLCI bytes.


Summary of changes:
 wiretap/ngsniffer.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)