Wireshark-commits: [Wireshark-commits] master-2.4 fd34a91: Check whether you've hit the end of the

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 Jan 2019 07:41:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=fd34a9174fcd50014c31a059bfdd899ef9df5731
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

fd34a91 by Guy Harris (guy@xxxxxxxxxxxx):

    Check whether you've hit the end of the packet data before going further.
    
    If we found no bytes with the low-order bit set in the packet data,
    there's no point in checking the non-existent "next" byte to see if it's
    a HDLC-style UI control byte (0x03).
    
    Bug: 15463
    Change-Id: Ibfd186e5b81d8ce229362e23f00b31a27900831a
    Reviewed-on: https://code.wireshark.org/review/31824
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 498b64c95c13980505e495bad33d911c26c52b8a)
    Reviewed-on: https://code.wireshark.org/review/31826
    

Actions performed:

    from  cb34e17   Rpcap authentication replies now have an optional payload.
     add  fd34a91   Check whether you've hit the end of the packet data before going further.


Summary of changes:
 wiretap/ngsniffer.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)