Wireshark-commits: [Wireshark-commits] master 6a7865e: CMake: strip directory prefixes from __FILE_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 21 Jan 2019 13:29:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6a7865e969e9c8e57b5ae0332930456a4cf6b705
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6a7865e by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: strip directory prefixes from __FILE__ macros
    
    Depending on the build location, the full source and/or build directory
    is currently visible in error messages (for example, DISSECTOR_ASSERT).
    Remove these to help with reproducible builds and have shorter messages.
    
    A similar option (-fdebug-prefix-map) is also needed, but it affects
    external debugging tools and is therefore better left to distributors
    (Debian and Arch Linux do this for example).
    
    Bug: 15163
    Change-Id: Icd8559bef2035f295aefbfc57ba6a342bfe76a41
    Reviewed-on: https://code.wireshark.org/review/31645
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  1963045   QUIC: rename "quic.frame_type.*" fields to "quic.*"
     add  6a7865e   CMake: strip directory prefixes from __FILE__ macros


Summary of changes:
 CMakeLists.txt | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)