Wireshark-commits: [Wireshark-commits] master 7c1d99c: CMake: do not set an invalid INSTALL_RPATH f

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 19 Jan 2019 23:41:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c1d99cb895a31e9b6d6263a16cad569737ec30f
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7c1d99c by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: do not set an invalid INSTALL_RPATH for (plugin) libraries
    
    CMAKE_INSTALL_RPATH also applies to libraries such as plugins. This
    should not happen when relative RPATHs (through $ORIGIN) are in use, so
    fix that.
    
    Change-Id: I154d93ba6ed66c2f78a42b25e352b5b54e9b8818
    Reviewed-on: https://code.wireshark.org/review/31609
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0c89d8c   Rename a Boolean flag variable to reflect the non-default behavior.
     add  7c1d99c   CMake: do not set an invalid INSTALL_RPATH for (plugin) libraries


Summary of changes:
 cmake/modules/WiresharkPlugin.cmake | 1 +
 1 file changed, 1 insertion(+)