Wireshark-commits: [Wireshark-commits] master 10ef540: CMake: avoid including file modification tim

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 18 Jan 2019 15:46:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=10ef54040502ce81cc20eb1b95068817cc96bc24
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

10ef540 by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: avoid including file modification time for RCC
    
    Resources such as translations (autogenerated qm files) and SVG images
    resulted in non-reproducible builds. Be sure to disable this to make the
    resources reproducible on Qt < 5.8 or Qt >= 5.9 (excluding Qt 5.8.x).
    
    With this change, the Wireshark build is reproducible invariant of the
    build directory (but not the source directory).
    
    Bug: 15163
    Change-Id: I9240d2aa6e7298e1928c0f1d97ce83673320024d
    Reviewed-on: https://code.wireshark.org/review/31593
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  d9fa91f   nas5gs: Add NAS 5GS media type dissection.
     add  10ef540   CMake: avoid including file modification time for RCC


Summary of changes:
 ui/qt/CMakeLists.txt | 9 +++++++++
 1 file changed, 9 insertions(+)