Wireshark-commits: [Wireshark-commits] master cda1a59: smpp: Make it clearer that it's a heuristic

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 Jan 2019 14:52:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cda1a591e9a835f626aacc0843a71bc6f25ce13b
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cda1a59 by Anders Broman (anders.broman@xxxxxxxxxxxx):

    smpp: Make it clearer that it's a heuristic dissector.
    
    Should this be default off? I had a false positive.
    While at it remove unused hf entry.
    
    Change-Id: Ia3ec0f2e127659349226af9bc2acb0812960a0a6
    Reviewed-on: https://code.wireshark.org/review/31574
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  75f9c95   CIP: Add more objects
     add  cda1a59   smpp: Make it clearer that it's a heuristic dissector.


Summary of changes:
 epan/dissectors/packet-smpp.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)