Wireshark-commits: [Wireshark-commits] master 00cb1e8: NTP: don't increment offsets that aren't use

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 08 Jan 2019 04:45:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=00cb1e8375a6bf3070422af99fb5898e56589963
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

00cb1e8 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    NTP: don't increment offsets that aren't used again.
    
    This avoids warnings from Clang.  Rewriting this to use the cursor API might
    be interesting.
    
    Change-Id: I8a5459ffbee8d0907757e99eff273d7eff6d1735
    Reviewed-on: https://code.wireshark.org/review/31436
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d76e32f   travis: do not run pip as root
     add  00cb1e8   NTP: don't increment offsets that aren't used again.


Summary of changes:
 epan/dissectors/packet-ntp.c | 31 -------------------------------
 1 file changed, 31 deletions(-)