URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29bfeccc8db0a880ad3aff282389298852c02323
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
29bfecc by Ross (whim42+github@xxxxxxxxx):
CRC6: Fixed CRC lookup table and functions
* Generated code and 256-element lookup table with pycrc
* Combined 2 crc6 functions which both have same poly 0x6f and lookup table
* Using the example file from the bug report,
$ tshark -r ~/Downloads/M1_header_crc.pcapng -V | grep "Calculated CRC"
1101 00.. = Header CRC: 0x34 [Calculated CRC 0x34]
Header and Calculated CRC are now both 0x34 (correct value)
* pycrc settings for generation:
$ python pycrc.py --reflect-in False \
--reflect-out False \
--xor-in 0 \
--xor-out 0 \
--algorithm table-driven
--width 6 \
--poly 0x2f
* To manually check 3GPP protocol header CRCs, use above command with flag
--check-hexstring=<HEADER HEX>
Bug: 14875
Change-Id: I283f52fcae10b2f92f107df6988629d49d692428
Reviewed-on: https://code.wireshark.org/review/31356
Reviewed-by: Ross Jacobs <rossbjacobs@xxxxxxxxx>
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 9aa63d2 epan: remove return from functions returning void.
add 29bfecc CRC6: Fixed CRC lookup table and functions
Summary of changes:
debian/libwsutil0.symbols | 3 +-
epan/crc6-tvb.c | 2 +-
epan/dissectors/packet-iuup.c | 10 +-
wsutil/crc6.c | 1115 ++---------------------------------------
wsutil/crc6.h | 3 +-
5 files changed, 58 insertions(+), 1075 deletions(-)