Wireshark-commits: [Wireshark-commits] master 7c04036: Windows: use lua-unicode as built with VS 20

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 03 Jan 2019 04:00:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c04036e7218cc73a059dd0f308382fda54d2a8a
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7c04036 by Peter Wu (peter@xxxxxxxxxxxxx):

    Windows: use lua-unicode as built with VS 2017
    
    These binaries were built by AppVeyor using VS 2017 (MSVC 19.16.27025.1)
    and replaces locally built binaries using VS 2015 (MSVC 19.0.24215.1).
    I believe that these are the same as both of them use VCRUNTIME140.dll
    and import the same symbols. Using a newer compiler should however
    remove any doubt of compatibility with VS 2017 and should address
    concerns from Anders and Graham.
    
    These files are actually the "msvc2017_*.zip" files from
    https://github.com/Lekensteyn/lua-unicode/releases/tag/5.2.4-release1
    
    Change-Id: Ib3fdf4678267fa10c0729f98ae0ce3153ac278a4
    Reviewed-on: https://code.wireshark.org/review/31307
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  9979de3   Don't fall out of the loop on a write error.
     add  7c04036   Windows: use lua-unicode as built with VS 2017


Summary of changes:
 tools/win-setup.ps1 | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)