Wireshark-commits: [Wireshark-commits] master-2.6 2b9e652: Windows: fix handling of Unicode paths i

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 02 Jan 2019 20:48:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2b9e65272da8332199e95e6ca659e644b56ab9bc
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

2b9e652 by Peter Wu (peter@xxxxxxxxxxxxx):

    Windows: fix handling of Unicode paths in Lua
    
    Lua internally uses ANSI C APIs (such as fopen). On many systems (macOS
    and Linux for example) these work fine with UTF-8. Windows however
    requires special Unicode APIs (such as _wfopen), so patch the Lua
    library to interpret paths are UTF-8 and call appropriate Unicode APIs.
    
    Changes compared to the previous LuaBinaries zip archive:
    
    - Patched with UTF-8 support for loadfile, os.execute, etc.
    - Built with VS 2015 (VCRUNTIME140.dll) instead of MinGW (MSVCRT.dll).
    - Includes PDB file for lua52.dll
    - Includes lua52.exe and luac52.exe with UTF-8 argv support (wmain).
    - Includes build scripts, source files and README.md.
    - Extra subdirectory named after the zip file.
    
    These zip files are taken from https://github.com/Lekensteyn/lua-unicode
    (the "prepared" source zips can be found here as well.)
    
    Bug: 15118
    Change-Id: I219f046d6e0fd5093287b5d6503a48ba7d1fc6a4
    Reviewed-on: https://code.wireshark.org/review/31165
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 604aef7164f50d1f547c7c3d2b0b811be6129e4a)
     [Peter: Removed "lua5.2.?-win??" since this old file only existed in an
      unreleased tag on master.]
    Reviewed-on: https://code.wireshark.org/review/31261
    

Actions performed:

    from  6afa42f   Remove older Visual Studio suport.
     add  2b9e652   Windows: fix handling of Unicode paths in Lua


Summary of changes:
 cmake/modules/FindLUA.cmake | 2 +-
 docbook/wsluarm.asciidoc    | 7 +++++++
 tools/win-setup.ps1         | 9 +++++----
 3 files changed, 13 insertions(+), 5 deletions(-)