Wireshark-commits: [Wireshark-commits] master ee23110: dpaux: Minor improvements

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 02 Jan 2019 08:26:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ee231105cc73ddcc8fc296915c2b626965439d17
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

ee23110 by Michael Mann (mmann78@xxxxxxxxxxxx):

    dpaux: Minor improvements
    
    1. Pass dissector data to dpaux dissector directly instead of using p_get_proto_data.
    2. Don't assume dissector data will always be present and default to "sink" if
    that is the case.
    3. tvb_memdup isn't needed for proto_tree_add_bytes
    4. Use value_string to save switch cases.
    5. Bugfix major/minor version dissection.
    
    Change-Id: I018d923537ce276fda8be1884f5bb3a8b2eef862
    Reviewed-on: https://code.wireshark.org/review/31297
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ae2a752   wsutil: fix crash due to corruption of the "small_buffers" array
     add  ee23110   dpaux: Minor improvements


Summary of changes:
 epan/dissectors/packet-dpaux.c    | 42 +++++++++-----------------
 epan/dissectors/packet-dpaux.h    |  2 --
 epan/dissectors/packet-dpauxmon.c | 63 +++++++++++++++++----------------------
 3 files changed, 41 insertions(+), 66 deletions(-)