Wireshark-commits: [Wireshark-commits] master-2.6 e5ccdb9: Qt: Open our preference dialogs via "cli

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 19 Dec 2018 18:32:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e5ccdb93defb49b8508edf71d4a448ee79dde92c
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

e5ccdb9 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Open our preference dialogs via "clicked" signals.
    
    In ModulePreferencesScrollArea we create QPushButtons that open modal
    UAT and file dialogs. Open them via the "clicked" signal instead of
    the "pressed" signal. "clicked" is a general activation signal that
    fires after the mouse button has been clicked+released or a keyboard
    event. "pressed" fires before "released" and can be problematic in
    some cases.
    
    Bug: 15366
    Change-Id: Icb353d86ae0a4b4b97e5f63df791ec562070756d
    Reviewed-on: https://code.wireshark.org/review/31124
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  4facf9d   Lua: Fix compilation with Lua 5.1.
     add  e5ccdb9   Qt: Open our preference dialogs via "clicked" signals.


Summary of changes:
 ui/qt/module_preferences_scroll_area.cpp | 16 ++++++++--------
 ui/qt/module_preferences_scroll_area.h   |  8 ++++----
 2 files changed, 12 insertions(+), 12 deletions(-)