Wireshark-commits: [Wireshark-commits] master 04b8558: Do not create a tvbuff on zero-length open t

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 18 Dec 2018 06:23:12 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04b8558f7dd584ff19b5dfc5f45ecbcefa2edb8d
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

04b8558 by Christophe GUERBER (christophe.guerber@xxxxxxxxx):

    Do not create a tvbuff on zero-length open type
    
    When decoding an open type in ASN.1/PER and the content length is zero,
    do not try to create a buffer. Doing so triggers an error in tvbuff.c.
    
    Ping-Bug: 15148
    Change-Id: If892e8c6a84cdfb268e3f6c50af0f7e30a89c59b
    Reviewed-on: https://code.wireshark.org/review/31088
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  eb4bf22   X2AP: fix dissection of MeNBtoSgNBContainer in SgNBModificationConfirm message
     add  04b8558   Do not create a tvbuff on zero-length open type


Summary of changes:
 epan/dissectors/packet-per.c | 2 ++
 1 file changed, 2 insertions(+)