URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba25ec205fe55bbfcc994f473c8e2484fe1567ea
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
ba25ec2 by Dylan Ulis (daulis0@xxxxxxxxx):
CIP: Minor code cleanup
dissect_cip_cm_data() was getting hard to read so:
1. Pull out some some logic into separate functions
dissect_cip_cm_unconnected_send_req
dissect_cip_cm_fwd_close_req
dissect_cip_cm_fwd_close_rsp_success
2. Reduce the scope of some variables.
No functional changes
Change-Id: I40c3dd5d2505b29991589ede4752c383348006ec
Reviewed-on: https://code.wireshark.org/review/31051
Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 8f6872e VOIP: Always use frame number when hashing sequence analysis.
add ba25ec2 CIP: Minor code cleanup
Summary of changes:
epan/dissectors/packet-cip.c | 255 ++++++++++++++++++++++---------------------
1 file changed, 130 insertions(+), 125 deletions(-)