Wireshark-commits: [Wireshark-commits] master d89cdf7: packet-rsl: Fix parsing values of some IE in

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 06 Dec 2018 11:22:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d89cdf76615807747ab21b8788b6a149157e2192
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d89cdf7 by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    packet-rsl: Fix parsing values of some IE in ip.access specific messages
    
    Those IEs have specific dissect methods that expect offset to point to
    the IE type, not to its value. Furthermore, those methods already add a
    subtree, so no need to create it for them.
    
    Related: https://osmocom.org/issues/3705
    Change-Id: Ia63253b95678b799f59ed945d1381f4eb01be636
    Reviewed-on: https://code.wireshark.org/review/30931
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  b455d8f   HI2Operations: update auto generated file and remove unused template
     add  d89cdf7   packet-rsl: Fix parsing values of some IE in ip.access specific messages


Summary of changes:
 epan/dissectors/packet-rsl.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)