Wireshark-commits: [Wireshark-commits] master 8992760: CMake: Fix Windows help install target

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 02 Dec 2018 22:00:44 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8992760c68f3e508a0e5a25307c246a75f7c2ae2
Submitter: "João Valverde <j@xxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8992760 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx):

    CMake: Fix Windows help install target
    
    We can't install from DATAFILE_DIR on this platform, we
    must use CMAKE_BINARY_DIR.
    
    Do that and try to keep this thing intact.
    
    Ping-Bug: 15301
    Change-Id: I5c0b787f8b1a148dda52f26242ab681e3c3a0d44
    Reviewed-on: https://code.wireshark.org/review/30879
    Petri-Dish: João Valverde <j@xxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: João Valverde <j@xxxxxx>
    

Actions performed:

    from  67720f7   RTP: ensure that _rtp_conversation_info strcuture is fully initialized
     add  8992760   CMake: Fix Windows help install target


Summary of changes:
 CMakeLists.txt      | 97 ++++++++++++-----------------------------------------
 help/CMakeLists.txt | 71 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 93 insertions(+), 75 deletions(-)
 create mode 100644 help/CMakeLists.txt