Wireshark-commits: [Wireshark-commits] master 7cc07bf: (D)TLS: defer RSA private key lookup until i

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Nov 2018 22:10:11 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7cc07bf7489fc5eef349c6aa862d6b109fe0d483
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7cc07bf by Peter Wu (peter@xxxxxxxxxxxxx):

    (D)TLS: defer RSA private key lookup until it is really needed
    
    RSA private keys can only be used for decrypting TLS sessions with a
    full handshake that use the RSA key exchange. However currently the RSA
    private key is always looked up even if it cannot be used (for example,
    due to an (EC)DHE cipher or due to a resumed session).
    
    Defer lookup of these private keys and make some more code conditional
    on the availability of GnuTLS at compile time since future changes
    switch to GnuTLS for RSA decryption.
    
    Change-Id: I31dfd6cdfbd733818c798b1fb0e895cf5a987c5a
    Reviewed-on: https://code.wireshark.org/review/30831
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d68b7bc   Add sip_call_id filter to RTP stream.
     add  7cc07bf   (D)TLS: defer RSA private key lookup until it is really needed


Summary of changes:
 epan/dissectors/packet-dtls.c      | 42 ++++++++++++++++----------
 epan/dissectors/packet-tls-utils.c | 62 +++++++++++++++++++++++---------------
 epan/dissectors/packet-tls-utils.h | 23 ++++++++------
 epan/dissectors/packet-tls.c       | 44 ++++++++++++++++-----------
 4 files changed, 104 insertions(+), 67 deletions(-)