Wireshark-commits: [Wireshark-commits] master 0da9763: Win32: change DLL search path to accomodate

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 29 Nov 2018 05:21:22 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0da9763d110da29491ac1e9206f5dc89906e357c
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0da9763 by Peter Wu (peter@xxxxxxxxxxxxx):

    Win32: change DLL search path to accomodate extcap and Npcap
    
    Extcap executables require libwsutil.dll from the program directory.
    These were loaded by setting the PATH environment variable, but this
    is not thread-safe (and caused sporadic tests failures as a result).
    Use SetDllDirectory instead, this also prevents loading DLL files
    from arbitrary directories in PATH.
    
    To make this work, the search logic for Npcap has to be modified to
    avoid relying on SetDllDirectory. This implies that Npcap cannot be
    used on Windows 7 anymore until KB2533623 (July 2011) is applied.
    
    Change-Id: I3fc42ff76e75ae162b6dd31103451fb8f71c09e6
    Reviewed-on: https://code.wireshark.org/review/30804
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  201b5c8   DOCSIS: Added Downstream Resequencing TLV (25.17)
     add  0da9763   Win32: change DLL search path to accomodate extcap and Npcap


Summary of changes:
 wsutil/file_util.c | 52 ++++++++++++++++++++++++++++++++++------------------
 wsutil/ws_pipe.c   | 16 ----------------
 2 files changed, 34 insertions(+), 34 deletions(-)