Wireshark-commits: [Wireshark-commits] master c344d45: addr_resolv: fix crashes in parse_ether_addr

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 23 Nov 2018 04:10:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c344d454b45b8a6f4ddf84c5e5d1164bb5647374
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

c344d45 by Peter Wu (peter@xxxxxxxxxxxxx):

    addr_resolv: fix crashes in parse_ether_address_fast
    
    When no mask is allowed, reject addresses like "aa:bb:cc:...".
    Fix the type of 'cp' to avoid reading from a negative array index.
    Fix parsing, a nibble is four bits, not eight.
    
    Bug: 15297
    Change-Id: Ibb0d0c17005b1e6213c09092e4b3c888a9024304
    Fixes: v2.9.0rc0-2629-g3bb32ede26 ("addr_resolv: add fast path for parsing addresses from manuf")
    Reviewed-on: https://code.wireshark.org/review/30768
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  802d4c0   text2pcap: make ethernet dummy header direction aware
     add  c344d45   addr_resolv: fix crashes in parse_ether_address_fast


Summary of changes:
 epan/addr_resolv.c | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)