Wireshark-commits: [Wireshark-commits] master-2.4 0398d9a: Fix reassembly of larger TACACS+ account

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 21 Nov 2018 08:30:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0398d9af1cdc292328a8d5076cb0cac8fff9561e
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

0398d9a by Jason Cohen (kryojenik2@xxxxxxxxx):

    Fix reassembly of larger TACACS+ accounting messages
    
    Since TACACS+ is TCP only, switched to tcp_dissect_pdus
    
    Bug: 15293
    Change-Id: I8cee8a1f474ae866c59f94ec8ecbd412e5189e89
    Reviewed-on: https://code.wireshark.org/review/30748
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/30750
    

Actions performed:

    from  e8fedc7   Fix expert info message for wrong option length.
     add  0398d9a   Fix reassembly of larger TACACS+ accounting messages


Summary of changes:
 epan/dissectors/packet-tacacs.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)