Wireshark-commits: [Wireshark-commits] master 3ab5211: test: convert capture tests to use fixtures,

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 16 Nov 2018 13:55:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3ab521118a0d068e0d5c795a5a57b13cd7790a75
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3ab5211 by Peter Wu (peter@xxxxxxxxxxxxx):

    test: convert capture tests to use fixtures, fix tests without dumpcap
    
    Add a new --capture-interface option to pytest, similar to test.py. It
    will grab some Ethernet interface on Windows. An empty value overrides
    this and disables capture tests. Remove the test.py --enable-capture
    option since that is implied by the --capture-interface option.
    
    Port the `test.py --program-path` option to pytest and additionally make
    the pytest look in the current working directory if neither WS_BIN_PATH
    nor --program-path are specified. Drop config.setProgramPath, this
    allows tests to be run even if not all binaries are available.
    
    With all capture tests converted to fixtures, it is now possible to run
    tests when Wireshark is not built with libpcap as tests that depend on
    cmd_dumpcap (or capture_interface) will be skipped.
    
    Bug: 14949
    Change-Id: Ie802c07904936de4cd30a4c68b6a5139e6680fbd
    Reviewed-on: https://code.wireshark.org/review/30656
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  cb9be38   tshark: do not print packet information when using -w without libpcap
     add  3ab5211   test: convert capture tests to use fixtures, fix tests without dumpcap


Summary of changes:
 test/conftest.py          |  29 +--
 test/fixtures.py          |  43 +++-
 test/fixtures_ws.py       |  58 ++++-
 test/subprocesstest.py    |  23 +-
 test/suite_capture.py     | 565 ++++++++++++++++++++++++----------------------
 test/suite_clopts.py      |  40 ++--
 test/suite_fileformats.py |  22 +-
 test/suite_io.py          |   2 +-
 test/suite_unittests.py   |   7 +-
 test/test.py              |  43 ++--
 10 files changed, 454 insertions(+), 378 deletions(-)