Wireshark-commits: [Wireshark-commits] master 13eefba: Fail more cleanly if the file has no records

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 14 Nov 2018 05:28:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=13eefba79c7944da8675727be65b31a04d9c330b
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

13eefba by Guy Harris (guy@xxxxxxxxxxxx):

    Fail more cleanly if the file has no records.
    
    If we have no records, we can't determine the link-layer type.
    
    Also:
    
    Use more signed values, and do more sanity checks on the file header and
    TLVs to make sure we don't run into the first packet.
    
    When writing the file header, accumulate the header length/first packet
    offset in a 32-bit variable, and stuff it into the
    offset-to-first-packet fields (plural) once we're done.
    
    Change-Id: I3aeb5258bc16ddd8cf0ec86ef379287d0c4b351a
    Reviewed-on: https://code.wireshark.org/review/30620
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  341c3f3   ieee80211: Avoid decrypting packets two times
     add  13eefba   Fail more cleanly if the file has no records.


Summary of changes:
 wiretap/network_instruments.c | 126 +++++++++++++++++++++++++++++++-----------
 1 file changed, 93 insertions(+), 33 deletions(-)