Wireshark-commits: [Wireshark-commits] master 2c09e87: Get rid of the radiotap tap.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Oct 2018 06:54:34 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2c09e87c713628362e4fdc33309a0cc205a20de3
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

2c09e87 by Guy Harris (guy@xxxxxxxxxxxx):

    Get rid of the radiotap tap.
    
    1) it doesn't supply any information not supplied by the new
    "wlan_radio" tap and, in fact, supplies less information (including not
    supplying any presence flags);
    
    2) it only works for radiotap headers, not for any other forms of radio
    metadata;
    
    3) its data structure wasn't declared in a header available to any
    listeners, it was defined internally to the radiotap dissector.
    
    Change-Id: Ie84a48bbf204b8b3bb40370c17ca82d39e5df3fb
    Reviewed-on: https://code.wireshark.org/review/30415
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  57c1eb3   Add a tap for the radio dissector that passes the pseudo-header.
     add  2c09e87   Get rid of the radiotap tap.


Summary of changes:
 epan/dissectors/packet-ieee80211-radiotap.c | 85 ++++++++---------------------
 1 file changed, 22 insertions(+), 63 deletions(-)