Wireshark-commits: [Wireshark-commits] master 5188a1a: checkAPIs: check ett variable registrations.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 21 Oct 2018 06:57:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5188a1a38ef44e4a5c2188c89838576fd18f55a9
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5188a1a by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    checkAPIs: check ett variable registrations.
    
    Using unregistered etts leads to an abort so check for them in checkAPIs.
    This does slow down checkAPIs by about 15% but it seems a reasonable cost
    for the benefit.
    
    Note that finding ett registration blocks was fairly inaccurate so we
    just check for whether ett variable addresses are used - on the assumption
    that if someone's using the address they're probably using it to register
    the ett.
    
    Change-Id: Ifbac75c4a8a0fdb27d9c9d1584a2de791bfbc118
    Reviewed-on: https://code.wireshark.org/review/30293
    Petri-Dish: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  233df2b   pw: make ett names longer.
     add  5188a1a   checkAPIs: check ett variable registrations.


Summary of changes:
 tools/checkAPIs.pl | 92 ++++++++++++++++++------------------------------------
 1 file changed, 30 insertions(+), 62 deletions(-)