Wireshark-commits: [Wireshark-commits] master 0e45da8: WSMP: Initialize a variable.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Oct 2018 20:59:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0e45da8cf3f8a9a1990d57b9675cf07d39f2f892
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0e45da8 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    WSMP: Initialize a variable.
    
    Fix
    
    ../epan/dissectors/packet-wsmp.c:359:9: error: variable 'psid' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
            default:
            ^~~~~~~
    ../epan/dissectors/packet-wsmp.c:369:9: note: uninitialized use occurs here
        if((psid == 0x20) && (IEEE1609dot2_handle)){
            ^~~~
    
    Change-Id: Ieb82a4c0ac8030a5bf8ddff962acb2f7c1711783
    Reviewed-on: https://code.wireshark.org/review/30255
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  55cd530   FindM.cmake: directly pass -lm to fix selective static linking
     add  0e45da8   WSMP: Initialize a variable.


Summary of changes:
 epan/dissectors/packet-wsmp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)