Wireshark-commits: [Wireshark-commits] master 178001e: lua: add support for ethernet addresses to t

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 18 Oct 2018 07:51:41 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=178001e74d42199d7cfadd668331a6bcdb3eeb42
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

178001e by Martin Kaiser (wireshark@xxxxxxxxx):

    lua: add support for ethernet addresses to the Address class
    
    The code for the Address class already contains commented-out code for a
    number of additional address types.
    
    Activate the draft constructor for ethernet addresses and complete it.
    Use the newly-added function to parse a string that contains an ethernet
    address.
    
    Add a basic test tvb.lua. Read an ethernet address from a tvb and
    compare it to a constant Address.ether object.
    
    Change-Id: I9771dd6e7ade4b572a8b864b8986d641b4eba3e5
    Reviewed-on: https://code.wireshark.org/review/30163
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  0f3a4db   tools/validate-commit.py: post-commit hook to check for commit issues
     add  178001e   lua: add support for ethernet addresses to the Address class


Summary of changes:
 epan/wslua/wslua_address.c | 26 +++++++++++++++++---------
 test/lua/tvb.lua           | 16 +++++++++++++++-
 2 files changed, 32 insertions(+), 10 deletions(-)