Wireshark-commits: [Wireshark-commits] master 460c265: test: reduce further influence from the envi

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2018 18:55:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=460c26516a3288a003aeeb01da35bf5cb6f210ad
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

460c265 by Peter Wu (peter@xxxxxxxxxxxxx):

    test: reduce further influence from the environment
    
    Some tests used the default home directory which can have side-effects
    (such as loading plugins, loading deprecated preferences). These could
    cause tests to fail. Always use a sane environment to fix this.
    
    Change getTsharkInfo to use this clean environment as well
    (WIRESHARK_CONFIG_DIR does not exist with master-2.6 and would also not
    propagate things like ASAN_OPTIONS=detect_leaks=0).
    
    Change-Id: I1674f71972d35de91d191e0c29fdb59b8a0a56ce
    Reviewed-on: https://code.wireshark.org/review/30165
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  fe9dcc1   test: fix DeprecationWarning: invalid escape sequence
     add  460c265   test: reduce further influence from the environment


Summary of changes:
 test/config.py          | 22 ++++++++++++++--------
 test/suite_clopts.py    |  4 ++--
 test/suite_text2pcap.py |  2 +-
 3 files changed, 17 insertions(+), 11 deletions(-)