Wireshark-commits: [Wireshark-commits] master-2.6 26c6460: DCOM: always NUL-terminate dissect_dcom_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 12 Oct 2018 08:52:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=26c6460e3cb131a4453bc8390596f6a14dce7292
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

26c6460 by Peter Wu (peter@xxxxxxxxxxxxx):

    DCOM: always NUL-terminate dissect_dcom_BSTR results
    
    All of the six users in plugins/epan/profinet/packet-dcom-cba.c expect
    the string to be NUL-terminated, so ensure this to avoid reading
    uninitialized memory for the Info column.
    
    Bug: 15130
    Change-Id: Ibc922068d14b87ce324af3cec22a5f8343088b40
    Reviewed-on: https://code.wireshark.org/review/30128
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ec6ace066ae4c889d4c18a0a38a8c6053483877b)
    Reviewed-on: https://code.wireshark.org/review/30158
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  e796366   wmem_tree: fix crash with wmem_tree_destroy and NULL scope
     add  26c6460   DCOM: always NUL-terminate dissect_dcom_BSTR results


Summary of changes:
 epan/dissectors/packet-dcom.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)