Wireshark-commits: [Wireshark-commits] master 9c61757: except: detect exception stack corruption

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 10 Oct 2018 04:08:25 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9c61757dc25dc359bb9666954667b4405a8a3825
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9c61757 by Peter Wu (peter@xxxxxxxxxxxxx):

    except: detect exception stack corruption
    
    Valgrind found an invalid read in the capture from Bug 15173 which was
    not detected by ASAN, probably because 'top' pointed to a valid stack
    address. Try to catch such issues with an explicit invariant check.
    
    Change-Id: I3e2d90f053209c133ea2edc9c7990a2fd39bd236
    Ping-Bug: 15189
    Reviewed-on: https://code.wireshark.org/review/30101
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  353ad11   checkAPIs.pl: check for return/goto in TRY/CATCH blocks
     add  9c61757   except: detect exception stack corruption


Summary of changes:
 epan/except.c | 1 +
 1 file changed, 1 insertion(+)