Wireshark-commits: [Wireshark-commits] master-2.4 5f36072: We should only link executables with set

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 07 Oct 2018 21:41:52 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5f360727b8f5af3eae2779adb96ae7d5ae81bcc8
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

5f36072 by Guy Harris (guy@xxxxxxxxxxxx):

    We should only link executables with setargv.obj.
    
    Libraries shouldn't be linked with it.
    
    See if this fixes the weird problems I'm having with mergecap -
    including, apparently, the mergecap from the buildbots - when run with
    wildcard arguments, terminating before it gets to main() (making it hard
    to try to debug bug 15151).
    
    Change-Id: Ie793b0ea8157186a121106636ac8b782457c09f5
    Reviewed-on: https://code.wireshark.org/review/29985
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 97972ea9ff4ba1dc485070197486bb5fffedf774)
    Reviewed-on: https://code.wireshark.org/review/30058
    

Actions performed:

    from  6c71315   [Automatic update for 2018-10-07]
     add  5f36072   We should only link executables with setargv.obj.


Summary of changes:
 CMakeLists.txt                 | 8 ++++++++
 cmake/modules/UseWinLibs.cmake | 3 ---
 2 files changed, 8 insertions(+), 3 deletions(-)