Wireshark-commits: [Wireshark-commits] master 29fbbfb: Qt/ByteViewTab: document potential pitfall

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 03 Oct 2018 03:52:51 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=29fbbfb3d39e801280d21e608bc269af4c1cd0cd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

29fbbfb by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt/ByteViewTab: document potential pitfall
    
    If ByteViewTab is related to a use-after-free crash, then the issue is
    probably related to the backing buffer becoming invalid. Document this.
    
    Change-Id: I7f7c8daaf86b42f00b7886de54507d425e5312f6
    Reviewed-on: https://code.wireshark.org/review/29924
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  e885798   s7comm dissector infinite loop error is fixed.
     add  29fbbfb   Qt/ByteViewTab: document potential pitfall


Summary of changes:
 ui/qt/byte_view_tab.cpp | 2 ++
 1 file changed, 2 insertions(+)