Wireshark-commits: [Wireshark-commits] master 97972ea: We should only link executables with setargv

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 02 Oct 2018 20:34:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=97972ea9ff4ba1dc485070197486bb5fffedf774
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

97972ea by Guy Harris (guy@xxxxxxxxxxxx):

    We should only link executables with setargv.obj.
    
    Libraries shouldn't be linked with it.
    
    See if this fixes the weird problems I'm having with mergecap -
    including, apparently, the mergecap from the buildbots - when run with
    wildcard arguments, terminating before it gets to main() (making it hard
    to try to debug bug 15151).
    
    Change-Id: Ie793b0ea8157186a121106636ac8b782457c09f5
    Reviewed-on: https://code.wireshark.org/review/29985
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  f439234   llc.c: Check ethertype 0x88DC and call the ethertype dissector.
     add  97972ea   We should only link executables with setargv.obj.


Summary of changes:
 CMakeLists.txt                 | 8 ++++++++
 cmake/modules/UseWinLibs.cmake | 3 ---
 2 files changed, 8 insertions(+), 3 deletions(-)