Wireshark-commits: [Wireshark-commits] master b59cadb: Clean up the epan_dissect_t in the normal co

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 29 Sep 2018 21:06:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b59cadb313207f3f2d27dc3d0e26568de39437d8
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b59cadb by Guy Harris (guy@xxxxxxxxxxxx):

    Clean up the epan_dissect_t in the normal code path.
    
    We initialized it, but only cleaned it up in an error code path, not in
    the regular code path.  That could leak memory.
    
    Change-Id: Icb5aa5b1a2df8919d8a4e54d88a5d865320bd279
    Reviewed-on: https://code.wireshark.org/review/29929
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  90d6219   Define the wtap_rec next to the Buffer.
     add  b59cadb   Clean up the epan_dissect_t in the normal code path.


Summary of changes:
 ui/qt/iax2_analysis_dialog.cpp | 2 ++
 1 file changed, 2 insertions(+)