URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=73644b3f766f1494d5c39b21adbc8c8cd1a6f7f7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
73644b3 by Peter Wu (peter@xxxxxxxxxxxxx):
checkAPIs.pl: speed up check_value_string_arrays and remove_if0_code
The initial execution time on packet-ieee80211.c was 940ms. Optimize:
- Assume that "static const value_string ... = { ... };" does not have
other preceding stuff (including optional whitespace). This speeds up
check_value_string_arrays and reduces runtime by 440ms to 500ms.
- Rewrite remove_if0_code to avoid invoking a substitution for every
line. This reduces runtime by 130ms to 370ms.
packet-rrc.c used to take 9.4s. The fixes improved it to 3.0s and 2.8s.
Change-Id: Ifc7efa447d64dccba3e211f0741099451b61b95a
Reviewed-on: https://code.wireshark.org/review/29794
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 95f7235 FP: Fix comments
add 73644b3 checkAPIs.pl: speed up check_value_string_arrays and remove_if0_code
Summary of changes:
tools/checkAPIs.pl | 116 ++++++++++++++++++++++++-----------------------------
1 file changed, 52 insertions(+), 64 deletions(-)