Wireshark-commits: [Wireshark-commits] master a6dc0c2: Don't use -Werror with Apple's llvm-gcc.

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 12 Sep 2018 04:22:39 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a6dc0c27fcc0c1a008c24daf8359f09a4d146965
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a6dc0c2 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use -Werror with Apple's llvm-gcc.
    
    Its handling of warnings, and of warnings-treated-as-errors, is horribly
    broken; once you've asked for a warning, and have specified -Werror,
    there appears to be nothing whatsoever that you can do to keep that
    warning from being an error *everywhere* in the code.
    
    Prior to change Ib591a1d6beaa13337d927a446b4d8d5e687ff610, the tests for
    warnings were all failing on the macOS buildbot, so *no* warnings were
    being requested.
    
    With this change, a warning won't be reported as an error, but at least
    it'll be reported.
    
    (We should probably switch to using Clang on the macOS buildbot at some
    point; I don't know whether the version of Clang currently on the
    buildbot is safe to use, but if we ever run a newer version of Xcode,
    which doesn't come with llvm-gcc - which may involve running a newer
    version of macOS on the buildbot as well - it's presumably safe, given
    that it's the only compiler Apple shipped.)
    
    Change-Id: I677967cb87b91f68f08de546e59abff1dbd6788b
    Reviewed-on: https://code.wireshark.org/review/29623
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  91c5942   QUIC: implement packet coalescing (draft >= 11)
     add  a6dc0c2   Don't use -Werror with Apple's llvm-gcc.


Summary of changes:
 CMakeLists.txt | 41 +++++++++++++++++------------------------
 1 file changed, 17 insertions(+), 24 deletions(-)