Wireshark-commits: [Wireshark-commits] master 8788780: Put the -Wno-error= options after -Werror.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Sep 2018 21:11:27 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=87887802ef05490a64e1f9b7eb8f219506042ea2
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

8788780 by Guy Harris (guy@xxxxxxxxxxxx):

    Put the -Wno-error= options after -Werror.
    
    It appears that -Werror overrides them, at least with llvm-gcc; I guess
    the options are evaluated in order.
    
    Change-Id: I0fd9e544a8e191a8950e17e97513912034763645
    Reviewed-on: https://code.wireshark.org/review/29615
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  7533398   OK, try just suppressing the "-Wunused-function" warning with llvm-gcc.
     add  8788780   Put the -Wno-error= options after -Werror.


Summary of changes:
 CMakeLists.txt | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)