Wireshark-commits: [Wireshark-commits] master 5bd04a3: sizeof isn't useful when adding to an offset

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 11 Sep 2018 03:20:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5bd04a317d1308c4a702965301ec431e466ba7ea
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5bd04a3 by Guy Harris (guy@xxxxxxxxxxxx):

    sizeof isn't useful when adding to an offset into the packet.
    
    Srsly, you're fetching a *two-byte* value, might as well say "2" -
    either sizeof(guint16) is guaranteed to be 2, in which case you might as
    well just use 2, or it's *not* guaranteed to be 2, in which case you
    *have* to use 2, because a value other than 2 is invalid.
    
    Change-Id: I9da8dc66d3a77e98cb0a0a5501655594c509eb87
    Reviewed-on: https://code.wireshark.org/review/29585
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  23c106b   Fix the build on the OSX buildbot
     add  5bd04a3   sizeof isn't useful when adding to an offset into the packet.


Summary of changes:
 epan/dissectors/packet-ieee80211.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)