Wireshark-commits: [Wireshark-commits] master-2.4 ed89e20: Don't use on-the-stack buffers for pinfo

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 08 Sep 2018 19:48:54 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed89e20b01fc2fa947233bcd745a0496af0cec77
Submitter: "Guy Harris <guy@xxxxxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

ed89e20 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use on-the-stack buffers for pinfo addresses.
    
    pinfo addresses are supposed to be valid after the routine that sets
    them exits; therefore, the data mustn't be on the stack.
    
    Change-Id: I7db48065b2cacad200fa6b18e19b68e130e535a5
    Reviewed-on: https://code.wireshark.org/review/29492
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 8dd322ba98b15a8dd967d7714bbedf28c4a8edce)
    Reviewed-on: https://code.wireshark.org/review/29494
    

Actions performed:

    from  ea84664   Add make-manuf.py to dist.
     add  ed89e20   Don't use on-the-stack buffers for pinfo addresses.


Summary of changes:
 epan/dissectors/packet-bthci_sco.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)