Wireshark-commits: [Wireshark-commits] master-2.4 2daeaa1: PER: fix dissection of enumerated type w

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Sep 2018 08:09:24 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2daeaa1c0c8e994a34f7d6dc0f9cf0313ba5092e
Submitter: "Pascal Quantin <pascal.quantin@xxxxxxxxx>"
Changed: branch: master-2.4
Repository: wireshark

Commits:

2daeaa1 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    PER: fix dissection of enumerated type with a single extension value
    
    Per X.691 chapter 14.3, a enumerated type with extension marcker should
    always be encoded as a normally small non-negative whole number.
    
    Change-Id: Ice070a932792ba1654674c68157ff4b6b0942f90
    Reviewed-on: https://code.wireshark.org/review/29454
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit e4ff3e657a8abfad75041cb9e6d750ca42764af0)
    Reviewed-on: https://code.wireshark.org/review/29458
    

Actions performed:

    from  94d5b91   Radius: Fix offset for multiple VSA in one AVP
     add  2daeaa1   PER: fix dissection of enumerated type with a single extension value


Summary of changes:
 epan/dissectors/packet-per.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)