Wireshark-commits: [Wireshark-commits] master e4ff3e6: PER: fix dissection of enumerated type with

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 07 Sep 2018 07:46:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e4ff3e657a8abfad75041cb9e6d750ca42764af0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

e4ff3e6 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    PER: fix dissection of enumerated type with a single extension value
    
    Per X.691 chapter 14.3, a enumerated type with extension marcker should
    always be encoded as a normally small non-negative whole number.
    
    Change-Id: Ice070a932792ba1654674c68157ff4b6b0942f90
    Reviewed-on: https://code.wireshark.org/review/29454
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4ff777d   [packet-cp2179.c] - Added support for Function Code 0x04 and perform misc comment & variable-name clean-ups
     add  e4ff3e6   PER: fix dissection of enumerated type with a single extension value


Summary of changes:
 epan/dissectors/packet-per.c | 19 +++++--------------
 1 file changed, 5 insertions(+), 14 deletions(-)