Wireshark-commits: [Wireshark-commits] master 0b80a42: epan: Guard g_base64_decode_inplace() agains

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 05 Sep 2018 17:19:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0b80a4218788284332a1fabef057d7c2b818f792
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

0b80a42 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    epan: Guard g_base64_decode_inplace() against zero length string
    
    The g_base64_decode_inplace() does not handle zero length string
    so add a guard for this before calling.
    
    Bug: 15113
    Change-Id: I89fa17dd62af238f4282835c317e5c8be6e0c8a1
    Reviewed-on: https://code.wireshark.org/review/29428
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  c15ada3   Update tools help using a script.
     add  0b80a42   epan: Guard g_base64_decode_inplace() against zero length string


Summary of changes:
 epan/dissectors/packet-http.c      | 30 ++++++++++++++--------
 epan/dissectors/packet-smtp.c      | 51 +++++++++++++++++++++++++++-----------
 epan/wslua/wslua_byte_array.c      | 16 ++++++------
 ui/qt/show_packet_bytes_dialog.cpp |  6 +++--
 4 files changed, 70 insertions(+), 33 deletions(-)